-
Notifications
You must be signed in to change notification settings - Fork 112
feat(atlas-local): Added Atlas Local List Deployments tool #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8370208 to
e6b0d15
Compare
src/server.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be done even before the import at line 207? Why do we want to attempt this if the tools are disabled? Or am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I missed this. Updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for streamable http, we'll have multiple sessions that will connect to the server and manage the local atlas env, do we think this is the best place to add set client or should we set it somewhere else? if you think we need a single client, you could check the transport file base.ts and how we inject DeviceId (long-running operation that blocks other calls) or Telemetry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is ok to have multiple instances of the client, it should not cause any issues
Could we also decouple the atlas local tests? in code-health we can have a Run Atlas Local tests and update the command in Run Atlas tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the changes and context, LGTM as we can split the tests as a follow-up
8a2db27
into
feat-MCP-40
Proposed changes
Ticket: [MCP-158] [mongodb-mcp-server] Implement listLocalAtlasClusters tool
Checklist